Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Feature) Disable gas estimation for WalletConnect#1790

Merged
Agupane merged 3 commits intorelease/v2.18.0from
feature/disable-gas-estimation-walletconnect
Jan 18, 2021
Merged

(Feature) Disable gas estimation for WalletConnect#1790
Agupane merged 3 commits intorelease/v2.18.0from
feature/disable-gas-estimation-walletconnect

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Jan 18, 2021

Description

  • We are having a problem with walletConnect, seems that web3.call is not returning a value of requiredTxGas, instead it's returning undefined. We put the same params (to, from and data) that we used on a test on metamask but the problems seems still there. So I'll disable the feature until we find a solution for walletConnect

@Agupane Agupane requested a review from dasanra January 18, 2021 17:57
@Agupane Agupane self-assigned this Jan 18, 2021
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jan 18, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 2 0
Ignored 1 N/A
  • Result: ✅ success

  • Annotations: 2 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 18, 2021

Travis automatic deployment:
https://pr1790--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 18, 2021

Travis automatic deployment:
https://pr1790--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Jan 18, 2021

Travis automatic deployment:
https://pr1790--safereact.review.gnosisdev.com/rinkeby/app

@Agupane Agupane merged commit f79f377 into release/v2.18.0 Jan 18, 2021
@Agupane Agupane deleted the feature/disable-gas-estimation-walletconnect branch January 18, 2021 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants