This repository was archived by the owner on Nov 10, 2023. It is now read-only.
(Feature) Disable gas estimation for WalletConnect#1790
Merged
Agupane merged 3 commits intorelease/v2.18.0from Jan 18, 2021
Merged
(Feature) Disable gas estimation for WalletConnect#1790Agupane merged 3 commits intorelease/v2.18.0from
Agupane merged 3 commits intorelease/v2.18.0from
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
[warning] @typescript-eslint/explicit-module-boundary-types
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
dasanra
approved these changes
Jan 18, 2021
|
Travis automatic deployment: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
web3.callis not returning a value ofrequiredTxGas, instead it's returningundefined. We put the same params (to, from and data) that we used on a test on metamask but the problems seems still there. So I'll disable the feature until we find a solution for walletConnect