Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Hotfix) Refund displayed as transaction rejection#1803

Merged
dasanra merged 4 commits intomasterfrom
hotfix/refund-displayed-as-rejection
Jan 22, 2021
Merged

(Hotfix) Refund displayed as transaction rejection#1803
dasanra merged 4 commits intomasterfrom
hotfix/refund-displayed-as-rejection

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Jan 21, 2021 •
edited
Loading

Closes #1800 by

@Agupane Agupane requested review from dasanra and fernandomg January 21, 2021 19:05
@github-actions
Copy link

github-actions bot commented Jan 21, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@Agupane Agupane requested a review from francovenica January 21, 2021 19:05
@github-actions
Copy link

github-actions bot commented Jan 21, 2021 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 21, 2021

Travis automatic deployment:
https://pr1803--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 21, 2021

Travis automatic deployment:
https://pr1803--safereact.review.gnosisdev.com/xdai/app

fernandomg
fernandomg approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@ghost
Copy link

ghost commented Jan 21, 2021

Travis automatic deployment:
https://pr1803--safereact.review.gnosisdev.com/volta/app

rmeissner
rmeissner approved these changes Jan 22, 2021
View reviewed changes
src/logic/safe/store/actions/transactions/utils/transactionHelpers.ts
return false
}

if (tx.gasToken && !isEmptyAddress(tx.gasToken)) {
Copy link
Contributor

@rmeissner rmeissner Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the existence check (tx.gasToken &&) is theoretically done also by isEmptyAddress, but doesn't harm to double check

src/logic/safe/store/actions/transactions/utils/transactionHelpers.ts
return false
}

if (tx.refundReceiver && !isEmptyAddress(tx.refundReceiver)) {
Copy link
Contributor

@rmeissner rmeissner Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@ghost
Copy link

ghost commented Jan 22, 2021

Travis automatic deployment:
https://pr1803--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 22, 2021

Travis automatic deployment:
https://pr1803--safereact.review.gnosisdev.com/xdai/app

@ghost
Copy link

ghost commented Jan 22, 2021

Travis automatic deployment:
https://pr1803--safereact.review.gnosisdev.com/volta/app

@dasanra dasanra merged commit 5bfc4bb into master Jan 22, 2021
@dasanra dasanra deleted the hotfix/refund-displayed-as-rejection branch January 22, 2021 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@francovenica francovenica Awaiting requested review from francovenica

3 more reviewers

@rmeissner rmeissner rmeissner approved these changes

@fernandomg fernandomg fernandomg approved these changes

@dasanra dasanra dasanra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Agupane Agupane

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Agupane @rmeissner @fernandomg @dasanra