Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Update 1 Inch app to v1.2.3#1816

Merged
dasanra merged 2 commits intodevelopmentfrom
feature/add-1-inch-app
Jan 27, 2021
Merged

Update 1 Inch app to v1.2.3#1816
dasanra merged 2 commits intodevelopmentfrom
feature/add-1-inch-app

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Jan 26, 2021

Update 1 Inch Safe App

@dasanra dasanra self-assigned this Jan 26, 2021
@github-actions
Copy link

github-actions bot commented Jan 26, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@dasanra
Copy link
Collaborator Author

dasanra commented Jan 26, 2021

@francovenica I think this one should be check on mainnet

https://ipfs.io/ipfs/QmRWtuktjfU6WMAEJFgzBC4cUfqp3FF5uN9QoWb55SdGG5/

@dasanra dasanra requested a review from francovenica January 26, 2021 12:30
@github-actions
Copy link

github-actions bot commented Jan 26, 2021 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 26, 2021

Travis automatic deployment:
https://pr1816--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 26, 2021

Travis automatic deployment:
https://pr1816--safereact.review.gnosisdev.com/volta/app

@francovenica
Copy link
Contributor

francovenica commented Jan 27, 2021 •
edited
Loading

Tested in prod mainnet: https://gnosis-safe.io/app/#/safes/0x8675B754342754A30A2AeF474D114d8460bca19b/transactions

Added the new app. Tried one swap and it worked fine for me just fine
image.png

@ghost
Copy link

ghost commented Jan 27, 2021

Travis automatic deployment:
https://pr1816--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 27, 2021

Travis automatic deployment:
https://pr1816--safereact.review.gnosisdev.com/volta/app

@dasanra dasanra merged commit fef88b0 into development Jan 27, 2021
@dasanra dasanra deleted the feature/add-1-inch-app branch January 27, 2021 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@francovenica francovenica francovenica approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dasanra dasanra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dasanra @francovenica