This repository was archived by the owner on Nov 10, 2023. It is now read-only.
WA-238 - Refactor Safe component#22
Merged
apanizo merged 9 commits intofeature/WA-238-withdraw-ethfrom Apr 27, 2018
Merged
Conversation
Contributor
Author
|
Travis automatic deployment: Storybook book automatic deployment: |
tschubotz
approved these changes
Apr 27, 2018
Contributor
tschubotz
left a comment
tschubotz
left a comment
There was a problem hiding this comment.
Looks good to me, couldn't find any bugs so far.
The Safe address is now cut off at some point (e.g. 0xa59f8de31d0b7b95521686092b03bf0c3...) which makes it currently impossible to copy the address without going to the source code.
But I think that's not an issue since we'll have a "copy address" button at some point anyway. On smaller screen widths it would be cut off anyway as well.
germartinez
approved these changes
Apr 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Due Diligence
## Description
This PR is just cosmetic changes on Safe component. Now the desktop view has space for adding extra components and allow user interaction (for example I will need that space for signing confirmations when withdrawing funds)
Dev Notes
For reviewing this PR I recommend do a "lexical" review on the code, and then clicking on the deployed instances create a safe and see it in the browser (for checking if layout is correct)