This repository was archived by the owner on Nov 10, 2023. It is now read-only.
WA-238 - Include daily limit component in UI#23
Merged
apanizo merged 6 commits intofeature/WA-238-withdraw-ethfrom May 2, 2018
Merged
WA-238 - Include daily limit component in UI#23apanizo merged 6 commits intofeature/WA-238-withdraw-ethfrom
apanizo merged 6 commits intofeature/WA-238-withdraw-ethfrom
Conversation
Contributor
Author
|
Travis automatic deployment: Storybook book automatic deployment: |
Contributor
Author
|
@tschubotz I have included a fix for being able to see the complete address in the safe view. Let me know if it works for you. |
tschubotz
suggested changes
Apr 27, 2018
Contributor
tschubotz
left a comment
tschubotz
left a comment
There was a problem hiding this comment.
Currently, it says that the daily limit is supposed to be at least 1. I think it could also be 0. It just has to be >=0 imo.
Contributor
Author
|
Travis automatic deployment: Storybook book automatic deployment: |
apanizo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Due Diligence
## Description
This PR introduces the Daily Limit component and information in all routes where it applies:
Also, it updates the immutable Safe record and all actions related to it, tests have been updated as well.
##Pictures
Dev Notes
For reviewing this PR I just recommend do a "lexical" review and also visit the storybook link for checking all routes.