This repository was archived by the owner on Nov 10, 2023. It is now read-only.
WA-238 - Use proxy contract and daily limit extension#24
Merged
apanizo merged 10 commits intofeature/WA-238-withdraw-ethfrom May 7, 2018
Merged
Conversation
Contributor
Author
|
Travis automatic deployment: Storybook book automatic deployment: |
Contributor
Author
|
Travis automatic deployment: Storybook book automatic deployment: |
apanizo
changed the base branch from
feature/WA-238-include-daily-limit
to
feature/WA-238-withdraw-eth
Contributor
Author
|
Travis automatic deployment: Storybook book automatic deployment: |
apanizo
deleted the
feature/WA-238-use-proxy-contract-and-daily-limit-extension
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Due Diligence
## Description
This PR creates safe instances through ProxyFactory, including the DailyLimitExtension. It checks if master contracts have been deployed. If so, it reuses them.
## Test notes
For testing it properly: