Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

WA-238 Safe Txs Frontend#30

Merged
apanizo merged 30 commits intofeature/WA-238-withdraw-ethfrom
feature/WA-238-safe-txs-frontend
May 31, 2018
Merged

WA-238 Safe Txs Frontend#30
apanizo merged 30 commits intofeature/WA-238-withdraw-ethfrom
feature/WA-238-safe-txs-frontend

Conversation

@apanizo
Copy link
Contributor

@apanizo apanizo commented May 26, 2018

Description
This PR allows to create tx and get them ready to be confirmed. If the safe has only one owner, the transaction is executed straight away.

This PR includes a DOM test simulating the second case: 1 safe with one owner and add a multisig tx and featured tests for new selectors created.

SEE:
screenshot 2018-05-26 13 40 46

SEE:
screenshot 2018-05-26 13 40 28

SEE:
screenshot 2018-05-26 13 45 44

Known bugs

  • Not creator owner can not operate with safe

Select account A in Metamask
Reload the connection in react-app
User A creates a new Safe with 3 owners (including user B and C as owners)
User A can see the new Safe in the list and can operate with it

Select account Z in Metamask
Reload the connection in react-app
User Z cannot see the new Safe in the list and cannot open it or operate with it

Select account B or C in Metamask
Reload the connection in react-app
User B/C can see the new Safe in the list but cannot open it or operate with it

apanizo added 30 commits May 21, 2018 16:09
@apanizo apanizo requested review from germartinez and tschubotz May 26, 2018 11:47
@apanizo
Copy link
Contributor Author

apanizo commented May 26, 2018

Travis automatic deployment:
https://staging-30-pr-182-safe-react-gnosis.surge.sh

Storybook book automatic deployment:
https://storybook-staging-30-pr-182-safe-react-gnosis.surge.sh

@apanizo apanizo merged commit 2c98b2e into feature/WA-238-withdraw-eth May 31, 2018
@apanizo apanizo deleted the feature/WA-238-safe-txs-frontend branch May 31, 2018 11:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant