WA-238 Implementation Multisig TXs#31
Conversation
|
Travis automatic deployment: Storybook book automatic deployment: |
|
Travis automatic deployment: Storybook book automatic deployment: |
There was a problem hiding this comment.
@apanizo just played around a bit with it. Here's what I found.
(1) Minor validation Bug:
- During Safe creation, enter 1.45346457 for number of confirmations
- Expected: Validation error saying, that I need to enter an integer.
- Observed: No error, it even is show on the Safe detail page

(2) Question:
Why do I need to add a transaction name? Is this like a description field when making a bank transfer or what was your intention behind this?

(3) Issue with confirmations
|
@tschubotz Question 1 and Question 3 should be fixed now, about Question 2 yeah, the idea was writing something in order to identify each transaction, probably that field should be removed because the smart contracts do not store that info, and at the end, the list of transactions will be retrieved from the backend service. |
|
Travis automatic deployment: Storybook book automatic deployment: |
tschubotz
left a comment
There was a problem hiding this comment.
Thanks for the update, the case with 1 confirmation works now for me!
(4) Another question though:
I tried to test the case where 2 confirmations are needed. Making the transaction works like a charm.
There seems to be a (UI?) bug though. After the tx was successful, it displays "3 confirmations needed" (see screenshot)

|
Travis automatic deployment: Storybook book automatic deployment: |
|
@tschubotz A couple of extra fixes implemented. Take a look when you have a chance. |


Description
In this PR I have introduced the logic for executing pending TXs once the threshold is reached. In other words, the functionality at UI level (remember I am using a very own mocked service) is "done".
@germartinez also the bug you reported related impossible usage of the safe for different owners is solved
@tschubotz Feel free to try it and let me know if you find any bug
See:

TODO
https://github.com/ethereum/wiki/wiki/JavaScript-API#web3ethgettransactionreceipt