Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

WA-238 Blockchain requirements#32

Merged
apanizo merged 24 commits intofeature/WA-238-withdraw-ethfrom
feature/WA-238-withdrawn-blockchain-requirements
Jun 4, 2018
Merged

WA-238 Blockchain requirements#32
apanizo merged 24 commits intofeature/WA-238-withdraw-ethfrom
feature/WA-238-withdrawn-blockchain-requirements

Conversation

@apanizo
Copy link
Contributor

@apanizo apanizo commented May 31, 2018

Description
This PR addresses some of the blockchain requirements of this ticket, which is the usage of a gas station for calculating gasPrice and also estimate the gas needed for withdrawn transactions (execution and confirmation).

This PR includes some bug fixes.

@apanizo apanizo requested review from germartinez and tschubotz May 31, 2018 11:57
@apanizo
Copy link
Contributor Author

apanizo commented May 31, 2018

Travis automatic deployment:
https://staging-32-pr-126-safe-react-gnosis.surge.sh

Storybook book automatic deployment:
https://storybook-staging-32-pr-126-safe-react-gnosis.surge.sh

@apanizo
Copy link
Contributor Author

apanizo commented Jun 1, 2018

Travis automatic deployment:
https://staging-32-pr-490-safe-react-gnosis.surge.sh

Storybook book automatic deployment:
https://storybook-staging-32-pr-490-safe-react-gnosis.surge.sh

@apanizo
Copy link
Contributor Author

apanizo commented Jun 1, 2018

Travis automatic deployment:
https://staging-32-pr-180-safe-react-gnosis.surge.sh

Storybook book automatic deployment:
https://storybook-staging-32-pr-180-safe-react-gnosis.surge.sh

tschubotz
tschubotz approved these changes Jun 1, 2018
View reviewed changes
Copy link
Contributor

@tschubotz tschubotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I test anything specific? everything seems to work for me!

@apanizo
Copy link
Contributor Author

apanizo commented Jun 4, 2018

Travis automatic deployment:
https://staging-32-pr-60-safe-react-gnosis.surge.sh

Storybook book automatic deployment:
https://storybook-staging-32-pr-60-safe-react-gnosis.surge.sh

germartinez
germartinez suggested changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@germartinez germartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Withdrawn button should be disabled when balance is 0ETH like Add button.

@apanizo
Copy link
Contributor Author

apanizo commented Jun 4, 2018

Travis automatic deployment:
https://staging-32-pr-178-safe-react-gnosis.surge.sh

Storybook book automatic deployment:
https://storybook-staging-32-pr-178-safe-react-gnosis.surge.sh

@apanizo
Copy link
Contributor Author

apanizo commented Jun 4, 2018

Travis automatic deployment:
https://staging-32-pr-455-safe-react-gnosis.surge.sh

Storybook book automatic deployment:
https://storybook-staging-32-pr-455-safe-react-gnosis.surge.sh

@apanizo apanizo merged commit 46a1737 into feature/WA-238-withdraw-eth Jun 4, 2018
@apanizo apanizo deleted the feature/WA-238-withdrawn-blockchain-requirements branch June 4, 2018 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@germartinez germartinez germartinez requested changes

@tschubotz tschubotz tschubotz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apanizo @tschubotz @germartinez