This repository was archived by the owner on Nov 10, 2023. It is now read-only.
WA-238 Checking tx receipt status on withdrawn mutlsig txs#35
Merged
apanizo merged 1 commit intofeature/WA-238-withdraw-ethfrom Jun 6, 2018
Merged
Conversation
Contributor
Author
|
Travis automatic deployment: Storybook book automatic deployment: |
tschubotz
approved these changes
Jun 5, 2018
Contributor
tschubotz
left a comment
tschubotz
left a comment
There was a problem hiding this comment.
Normale transactions work for me.
I cannot make the transaction fail on purpose. If I set the gas price to 0, then MetaMask drop the transaction. If I set the gas limit to 21k, then it's automatically raised to the required amount again by MetaMask (?) again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before those changes I was relying on try/catch for identifying errors, it seems on
mainnetandrinkebyandmainnet, if the tx fails no exception is raised, so I had to check the status field.