Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@katspaugh
Copy link
Member

What it solves

Shows a banner with our new URL and a redirect after a 10-second countdown.

Screenshot 2022-11-03 at 09 54 00

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3384248745

  • 0 of 24 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 41.836%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/PsaBanner/index.tsx 0 7 0.0%
src/components/PsaBanner/Countdown.tsx 0 17 0.0%
Files with Coverage Reduction New Missed Lines %
src/logic/safe/hooks/useOwnerSafes.ts 1 95.83%
Totals Coverage Status
Change from base Build 3321854842: -0.09%
Covered Lines: 4777
Relevant Lines: 10425

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

Ok, had to check in my localhost to see the banner.
LGTM

The redirection works
The cancel button and close button (the "X") stop the redirect
The URL in the banner is fine
Once closed the banner doesn't show up anymore (expected)

image

@katspaugh katspaugh merged commit 897cade into dev Nov 7, 2022
@katspaugh katspaugh deleted the redirect-banner branch November 7, 2022 07:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants