This repository was archived by the owner on Nov 10, 2023. It is now read-only.
Fix correct linking for token allocation #4111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Link from allocation widget in header to open the Safe App is malformed, missing
/appand reloads the whole web. Somehow in web is working but the desktop app is not able to resolve the link.How this PR fixes it
Use react-router to navigate to the correct route
How to test it
Check that in prod the
/appis missing when hovering the allocation widget in the headerStyles should be exactly the same. Link should correctly redirect to the Safe App
In the desktop app without this fix, app is not correctly redirected. If we use a normal link the current Wallet is disconnected