Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Nov 4, 2022

What it solves

Link from allocation widget in header to open the Safe App is malformed, missing /app and reloads the whole web. Somehow in web is working but the desktop app is not able to resolve the link.

How this PR fixes it

Use react-router to navigate to the correct route

How to test it

Check that in prod the /app is missing when hovering the allocation widget in the header
Styles should be exactly the same. Link should correctly redirect to the Safe App

In the desktop app without this fix, app is not correctly redirected. If we use a normal link the current Wallet is disconnected

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3395483432

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 41.921%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/AppLayout/Header/components/SafeTokenWidget/index.tsx 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/logic/safe/hooks/useOwnerSafes.ts 1 95.83%
Totals Coverage Status
Change from base Build 3321854842: -0.006%
Covered Lines: 4777
Relevant Lines: 10403

💛 - Coveralls

@katspaugh katspaugh merged commit 5bf0906 into dev Nov 7, 2022
@katspaugh katspaugh deleted the fix-token-allocation-link branch November 7, 2022 07:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants