-
Notifications
You must be signed in to change notification settings - Fork 357
fix: prevent redirection flag #4113
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 3419349979
💛 - Coveralls |
katspaugh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, adding ?no-redirect=true does prevent the redirect.
Unfortunately, this param isn't preserved when navigating to another route.
I'd suggest to set the banner_closed LS to true if the query param is present.
katspaugh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works as expected. After a refresh, there's no redirect if the previous visit had no-redirect. ✅
What it solves
Preventing redirection to new deployment.
How this PR fixes it
When the
no-redirectsearch parameter is present, redirection to the new deployment doesn't occur.How to test it
Add
?no-redirect=trueto the end of the URL and observe that the redirection is not present in the banner.Note: the banner close flag will need to be removed from the
localStorage.