This repository was archived by the owner on Mar 10, 2026. It is now read-only.
feat: notification settings page improvements#254
Merged
Conversation
added 2 commits
March 8, 2026 14:38
- rename "Mobile In-App Notifications" to "In-App Notifications"; show on all platforms (was mobile-only) - rename "Notification Sound" to "In-App Notification Sound" to clarify it only controls in-page audio, not push sound - move badge display settings (Show Unread Counts, Badge Counts for DMs Only, Show Unread Ping Counts) from Appearance to Notifications - add NotificationLevelsHint info popover to All/Special/Keyword sections explaining Disable / Notify Silent / Notify Loud - add descriptive text under each notification section heading - show a single Mention @room control (IsRoomMention on modern servers, AtRoomNotification on old servers) — they are spec-mandated mirrors and exposing both as independent controls was confusing - clarify @room push rule labels and descriptions - add "Follows your global notification rules" subtitle to the Default option in the per-room notification switcher
7w1
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the Notifications settings page and the per-room notification switcher. No behaviour changes — purely UI/labelling improvements.
Changes
@roompush rules — "Mention @room" now shows a single control routing toIsRoomMention(MSC3952) on modern servers orAtRoomNotificationon older ones. Showing both as independent toggles was confusing and caused an apparent sync loop.Changed files
src/app/features/settings/notifications/SystemNotification.tsxsrc/app/features/settings/notifications/AllMessages.tsxsrc/app/features/settings/notifications/SpecialMessages.tsxsrc/app/features/settings/notifications/KeywordMessages.tsxsrc/app/features/settings/notifications/NotificationLevelsHint.tsxsrc/app/features/settings/cosmetics/Themes.tsxsrc/app/components/RoomNotificationSwitcher.tsx