This repository was archived by the owner on Mar 10, 2026. It is now read-only.
fix: add element-call multi-stage build to Dockerfile#271
Closed
Just-Insane wants to merge 2 commits into
Closed
Conversation
upstream/dev added the element-call submodule as a file: dependency (@element-hq/element-call-embedded) but the Dockerfile had no step to build it, causing the vite static-copy plugin to fail with: No file was found to copy on node_modules/@element-hq/element-call-embedded/dist/* Add a new element-call-builder stage that: - Fetches the pinned submodule commit with --depth=1 - Enables corepack to activate yarn 4.x (required by packageManager field) - Runs yarn build:embedded to produce embedded/web/dist/ The builder stage then COPYs the pre-built package into place before npm ci, so npm can resolve the file: dep and vite finds the assets.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
sable | 78bd6cb | Mar 09 2026, 12:47 PM |
Owner
|
Not needed yet since we reverted avatars. Maybe needed again later but we’ll see :p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After merging the "avatars!" PR (#227), which added
element-callas a git submodule and@element-hq/element-call-embeddedas afile:element-call/embedded/webdependency, Docker builds fail with:The Dockerfile had no step to fetch or build the submodule, so
embedded/web/dist/was never populated.Solution
Add a new
element-call-builderstage before the mainbuilderthat:ecef381c) from the element-call repo with--depth=1corepack enableto activate Yarn 4.x (the repo'spackageManagerfield requires it — the Alpine Node image only ships Yarn 1.x)yarn build:embeddedfrom the repo root, which outputs toembedded/web/dist/The
builderstage then usesCOPY --from=element-call-builderto place the pre-built package atelement-call/embedded/webbeforenpm ciruns, so npm resolves thefile:dependency and vite finds thedist/assets.