This repository was archived by the owner on Jan 23, 2025. It is now read-only.
Add retry functionality to delete firewall settings#35
Merged
Conversation
Be able to catch and retry error code 40001, if previous firewall configuration not yet finished.
dentarg
approved these changes
May 11, 2023
Contributor
Author
|
Reported in cloudamqp/terraform-provider-cloudamqp#205 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Lack of retry delete firewall settings like create/update do. Can cause nuhandled error if previous firewall rules not finished configuring.
WHAT is this pull request doing?
HOW can this pull request be tested?
Locally change latest firewall settings to configure=false. Let it retry until it's set to true again.