This repository was archived by the owner on Jan 23, 2025. It is now read-only.
Don't wait on state change for required plugin#37
Merged
Conversation
dentarg
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When enable/disable plugins in async way, we wait for state to change in order to know the action has been done. While plugins we choose to be mandatory cannot be enabled/disabled by our users. Bug reported: cloudamqp/terraform-provider-cloudamqp#227 about stuck in destroy loop waiting for change.
WHAT is this pull request doing?
Check if plugin is required while waiting on state change. If true, don't wait on state change.
HOW can this pull request be tested?
Destroy a plugin resource with a mandatory plugin (rabbitmq_prometheus) with a none developer user.