This repository was archived by the owner on Jan 23, 2025. It is now read-only.
Conversation
dentarg
approved these changes
Dec 6, 2023
Contributor
dentarg
left a comment
dentarg
left a comment
There was a problem hiding this comment.
Looks good to me, haven't tested this myself
tbroden84
added a commit
that referenced
this pull request
Dec 12, 2023
### WHY are these changes introduced? Introducing GCP Private Service Connect support in our API backend. Merges all three "PrivateLink" into new endpoint routes. ### WHAT is this pull request doing? - Add new endpoint for `vpc-connect` ### HOW can this pull request be tested? Run together with our CloudAMQP Terraform provider.
tbroden84
added a commit
to cloudamqp/terraform-provider-cloudamqp
that referenced
this pull request
Dec 14, 2023
### WHY are these changes introduced? Introducing GCP Private Service Connect support in our API backend. Similar to AWS/Azure PrivateLink. Merge all resources into one new resource that are capable to handle all three platform provider in one single resource. Requires: 84codes/go-api#41 ### WHAT is this pull request doing? - Add single resource capable to handle all three platform providers. - Add new VPC connect documentation. - Update PrivateLink documentation. ### HOW can this pull request be tested? Setup PrivateLink/Private Service connection for each platform provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Introducing GCP Private Service Connect support in our API backend. Merges all three "PrivateLink" into new endpoint routes.
WHAT is this pull request doing?
vpc-connectHOW can this pull request be tested?
Run together with our CloudAMQP Terraform provider.