This repository was archived by the owner on Jan 23, 2025. It is now read-only.
Conversation
tbroden84
changed the title
tbroden84
added a commit
that referenced
this pull request
Dec 12, 2023
### WHY are these changes introduced? Reported issues when trying to delete VPCs that has already been deleted when using our CloudAMQP Terraform provider. This can happen if deleting the instance without setting `keep_associated_vpc = true` and running `terraform destroy`. Extend the status code handling to respond with a warning instead of throwing an error. Require: 84codes/customer-console#271 ### WHAT is this pull request doing? - Handle status code 410 (gone) for the VPC - Prepare to handle status code 410 (gone) for the instance - Clean up the code ### HOW can this pull request be tested? Manual tested locally against our CloudAMQP Terraform provider. By destroying the instance (with `keep_associated_vpc = false`) before destroying the VPC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Reported issues when trying to delete VPCs that has already been deleted when using our CloudAMQP Terraform provider. This can happen if deleting the instance without setting
keep_associated_vpc = trueand runningterraform destroy. Extend the status code handling to respond with a warning instead of throwing an error.Require: https://github.com/84codes/customer-console/pull/271
WHAT is this pull request doing?
HOW can this pull request be tested?
Manual tested locally against our CloudAMQP Terraform provider. By destroying the instance (with
keep_associated_vpc = false) before destroying the VPC.