Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Add and update GCP VPC peering with retries#43

Merged
tbroden84 merged 5 commits intomainfrom
gcp-vpc-peering-retries
Dec 18, 2023
Merged

Add and update GCP VPC peering with retries#43
tbroden84 merged 5 commits intomainfrom
gcp-vpc-peering-retries

Conversation

@tbroden84
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Reported issues about "Timeout talking to backend" and lack of retries when fetching peering information. Also overall lack of configurable retries or endless loops.

WHAT is this pull request doing?

  • Make retries configurable through sleep and timeout
  • Add retry for request and keep track on attempts made
  • Re-use retry and wait func between instanceID or vpcID requests.
  • Clean up code

HOW can this pull request be tested?

Manual make VPC peering through our CloudAMQP Terraform provider for clusters hosted in GCP.

@tbroden84 tbroden84 merged commit c1a43f9 into main Dec 18, 2023
@tbroden84 tbroden84 deleted the gcp-vpc-peering-retries branch December 18, 2023 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants