Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Update notification to use recipient ID parameter#45

Merged
tbroden84 merged 1 commit intomainfrom
update-notification
Feb 15, 2024
Merged

Update notification to use recipient ID parameter#45
tbroden84 merged 1 commit intomainfrom
update-notification

Conversation

@tbroden84
Copy link
Copy Markdown
Contributor

@tbroden84 tbroden84 commented Feb 9, 2024

WHY are these changes introduced?

When updating the notification recipient, we previously used the params to identify the recipient.
Make it more clear and use recipient ID input parameter instead.

WHAT is this pull request doing?

  • Adds recipientID as input parameter for update and delete
  • Cleans up the code

HOW can this pull request be tested?

Manual test with the provider.

Copy link
Copy Markdown
Contributor

@dentarg dentarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@tbroden84 tbroden84 changed the title Fix: notification update with recipient ID Update notification to use recipient ID parameter Feb 15, 2024
@tbroden84 tbroden84 merged commit fda4e42 into main Feb 15, 2024
@tbroden84 tbroden84 deleted the update-notification branch February 15, 2024 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants