This repository was archived by the owner on Jan 23, 2025. It is now read-only.
Add retry functionality for Webhook endpoints#50
Merged
Conversation
dentarg
approved these changes
Apr 25, 2024
Contributor
dentarg
left a comment
dentarg
left a comment
There was a problem hiding this comment.
I trust you have tested this :) LGTM
Contributor
Author
|
Yes, tested some more scenarios again since I found an issue in the provider. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Underlying handling of webhooks relies on RPC request.
Follow similar pattern as other endpoints and use retry functionality.
WHAT is this pull request doing?
Adds retry functionality to CRUD endpoints.
HOW can this pull request be tested?
Test together with cloudamqp/terraform-provider-cloudamqp#268