[feat] filters paths]#231
Merged
Merged
Conversation
Owner
8ball030
commented
Aug 8, 2024
8ball030
commented
- first-commit
- fixes: lockfile out of date
8ball030
commented
Aug 8, 2024
| echo "Host poetry executable: $host_poetry_executable" | ||
| echo "Setting up new poetry environment..." | ||
|
|
||
| poetry env use $(which python) |
Owner
Author
There was a problem hiding this comment.
@xiuxiuxar I FOUND IT!!!!
THIS THING HAS CAUSED US SO MUCH ERRORS!
| def cli_runner(): | ||
| """Fixture for invoking command-line interfaces.""" | ||
| return CliRunner() | ||
| return CommandExecutor |
Owner
Author
There was a problem hiding this comment.
@Karrenbelt checkit out, we now use the command executor as the exector for the tests.
Collaborator
There was a problem hiding this comment.
I don't think this is a good idea:
- This runs a subprocess instead of invoking the CLI tool as a Python object.
- It does not return the exit code.
- It does not capture logs.
- Several tests that rely on
click.CliRunnerhave been disabled as a result.
| assert "http_dialogues" in skill_yaml["models"] | ||
|
|
||
|
|
||
| @pytest.mark.skip(reason="Needs chain contracts update") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.