Add websocket shutdown grace period #3653
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-markham
force-pushed
the
ws-close-grace-period
branch
from
9461546 to
1a8cbc6
Compare
john-markham
changed the title
Collaborator
|
@john-markham Hey, I'm just curious what the status of this is. There was a flurry of other websocket activity, and I got confused where this PR fits with all that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler approach to graceful shut down than #3638. Got this idea from following the discussion around gorilla/websocket#248
Relying explicitly on the handshake complicates the implementation past what I think is worth it if alternatives like this could get us 80% of the way there.
I'm still validating that hypothesis. Work to address #3633
I have: