Skip to content

Conversation

@jchung01
Copy link
Contributor

Main goal of this PR is to fix the network leaks, which look like LEAK: ByteBuf.release() was not called before it's garbage-collected; I found the EnderStorage bug while I was diagnosing the CodeChickenLib (CCL) leak.

Fix OpenComputers (OC) not releasing their packets.

Fix CCL not releasing their PacketCustom payloads.

Fix EnderStorage adding duplicate Frequency entries in TankSynchronizer.

  • This was because Frequency broke the Object equality contract by overriding hashCode() but not equals().

Debugging the network pipeline is confusing 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants