Add eclair-cli to eclair's docker image#1063
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1063 +/- ##
==========================================
+ Coverage 82.31% 82.37% +0.06%
==========================================
Files 99 99
Lines 7553 7553
Branches 284 284
==========================================
+ Hits 6217 6222 +5
+ Misses 1336 1331 -5
|
Member
|
Is there a way to have docker hub pick up this branch? |
Contributor
Author
Yes, the tag i pushed was successfully built https://hub.docker.com/r/acinq/eclair/builds |
pm47
requested changes
Jul 4, 2019
Member
pm47
left a comment
There was a problem hiding this comment.
Seems like you are missing curl:
$ docker container ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
cd2e64e083e7 acinq/eclair:cli_in_docker "/bin/sh -c 'java $J…" 55 seconds ago Up 54 seconds flamboyant_matsumoto
$ docker exec cd2e64e083e7 eclair-cli -p bar getinfo
This tool requires curl.
pm47
approved these changes
Jul 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the command line tool
eclair-clito the eclair docker image, this will allow users to easily interact with their eclair instance viadocker exec.cc: @Kukks