Skip to content

Add eclair-cli to eclair's docker image#1063

Merged
araspitzu merged 4 commits into
masterfrom
eclair_cli_in_docker
Jul 5, 2019
Merged

Add eclair-cli to eclair's docker image#1063
araspitzu merged 4 commits into
masterfrom
eclair_cli_in_docker

Conversation

@araspitzu
Copy link
Copy Markdown
Contributor

Add the command line tool eclair-cli to the eclair docker image, this will allow users to easily interact with their eclair instance via docker exec.

cc: @Kukks

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 4, 2019

Codecov Report

Merging #1063 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
+ Coverage   82.31%   82.37%   +0.06%     
==========================================
  Files          99       99              
  Lines        7553     7553              
  Branches      284      284              
==========================================
+ Hits         6217     6222       +5     
+ Misses       1336     1331       -5
Impacted Files Coverage Δ
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 83.69% <0%> (+0.18%) ⬆️
...clair/blockchain/electrum/ElectrumClientPool.scala 75.26% <0%> (+1.07%) ⬆️
...cinq/eclair/blockchain/bitcoind/zmq/ZMQActor.scala 94.87% <0%> (+5.12%) ⬆️

@pm47
Copy link
Copy Markdown
Member

pm47 commented Jul 4, 2019

Is there a way to have docker hub pick up this branch?

@araspitzu
Copy link
Copy Markdown
Contributor Author

Is there a way to have docker hub pick up this branch?

Yes, the tag i pushed was successfully built https://hub.docker.com/r/acinq/eclair/builds

Copy link
Copy Markdown
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you are missing curl:

$ docker container ps
CONTAINER ID        IMAGE                        COMMAND                  CREATED             STATUS              PORTS               NAMES
cd2e64e083e7        acinq/eclair:cli_in_docker   "/bin/sh -c 'java $J"   55 seconds ago      Up 54 seconds                           flamboyant_matsumoto

$ docker exec cd2e64e083e7 eclair-cli -p bar getinfo
This tool requires curl.

@araspitzu araspitzu merged commit 9afb26e into master Jul 5, 2019
@araspitzu araspitzu deleted the eclair_cli_in_docker branch July 5, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants