Check TLS version support in ElectrumClient#1216
Merged
Merged
Conversation
t-bast
approved these changes
Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1160 updated netty, and
ElectrumClientnow usesTLSv1.3when using the custom electrum server feature. However mobile devices may not support TLS 1.3 (for android, only from 10/API 29):As such trying to enable
TLSv1.3inElectrumClientraises an exception on older Android. It does not gracefully fallback toTLSv1.2as was expected.This PR fixes that by checking support beforehand.