Better Bolt 11 parsing spec compliance#1302
Closed
t-bast wants to merge 4 commits into
Closed
Conversation
Correctly implement skipping over hashed tags with invalid length. See lightning/bolts#736.
Codecov Report
@@ Coverage Diff @@
## master #1302 +/- ##
==========================================
+ Coverage 77.52% 78.35% +0.83%
==========================================
Files 144 144
Lines 10098 10756 +658
Branches 390 429 +39
==========================================
+ Hits 7828 8428 +600
- Misses 2270 2328 +58
|
sstone
reviewed
Feb 4, 2020
sstone
approved these changes
Feb 6, 2020
pm47
reviewed
Feb 7, 2020
Member
pm47
left a comment
There was a problem hiding this comment.
I think I have another idea, will try and let you know.
|
|
||
| // @formatter:off | ||
| case class UnknownTag0(data: BitVector) extends UnknownTaggedField | ||
| case class UnknownTag1(data: BitVector) extends UnknownTaggedField |
Member
|
Here is my take: #1308. |
Member
Author
|
Closing in favor of #1308 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more Bolt 11 spec tests.
Ignore hashed fields with invalid length as the spec requires:
See lightning/bolts#699 and lightning/bolts#736.