Configure bitcoin wallet#1540
Merged
Merged
Conversation
We wrap these exceptions but preserve the original one.
It makes sense to allow users to use a different wallet from the default one. There's one important caveat: once set, users shouldn't change it while they have open channels. We mention it clearly in the documentation.
pm47
reviewed
Sep 24, 2020
|
LGTM |
pm47
reviewed
Sep 28, 2020
pm47
approved these changes
Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes sense to allow users to use a different wallet from the default one.
There's one important caveat: once set, users shouldn't change it while they have open channels.
We mention this clearly in the documentation, I don't think we need an explicit mechanism in the code to prevent starting with a different wallet (for example, if no channels are open, it's safe to change your wallet). It's use-at-your-own-risk if users choose to ignore the documented caveats. @darwin is that trade-off ok?
Fixes #1538