Skip to content

Use warning messages for connection issues#1863

Merged
t-bast merged 3 commits into
masterfrom
warning-messages
Jul 6, 2021
Merged

Use warning messages for connection issues#1863
t-bast merged 3 commits into
masterfrom
warning-messages

Conversation

@t-bast
Copy link
Copy Markdown
Member

@t-bast t-bast commented Jul 6, 2021

lightning/bolts#834 recommends sending warning messages instead of connection-level errors in some cases, which avoids unnecessary channel closure.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #1863 (3c7c0ee) into master (4ca5c62) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1863      +/-   ##
==========================================
- Coverage   88.96%   88.92%   -0.04%     
==========================================
  Files         150      150              
  Lines       11250    11254       +4     
  Branches      457      467      +10     
==========================================
  Hits        10008    10008              
- Misses       1242     1246       +4     
Impacted Files Coverage Δ
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.19% <0.00%> (-0.09%) ⬇️
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 89.52% <0.00%> (-0.06%) ⬇️
...main/scala/fr/acinq/eclair/io/PeerConnection.scala 84.16% <57.14%> (-0.52%) ⬇️
...main/scala/fr/acinq/eclair/router/Validation.scala 90.76% <0.00%> (-1.54%) ⬇️
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala 96.87% <0.00%> (+0.78%) ⬆️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 97.63% <0.00%> (+1.57%) ⬆️

lightning/bolts#834 recommends sending
warning messages instead of connection-level errors in some cases, which
avoids unnecessary channel closure.
@t-bast t-bast force-pushed the warning-messages branch from 9bd0548 to 1a00bd4 Compare July 6, 2021 10:20
@t-bast t-bast marked this pull request as ready for review July 6, 2021 10:26
@t-bast t-bast requested a review from pm47 July 6, 2021 10:26
Copy link
Copy Markdown
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you did there! 😉

Comment thread eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala Outdated
Comment thread eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala Outdated
Comment thread eclair-core/src/main/scala/fr/acinq/eclair/io/PeerConnection.scala Outdated
Comment thread eclair-core/src/main/scala/fr/acinq/eclair/io/PeerConnection.scala
pm47
pm47 previously approved these changes Jul 6, 2021
Comment thread eclair-core/src/main/scala/fr/acinq/eclair/io/PeerConnection.scala Outdated
@t-bast t-bast merged commit d9a03a5 into master Jul 6, 2021
@t-bast t-bast deleted the warning-messages branch July 6, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants