Use the BlockHeight type wherever it makes sense#2129
Merged
Conversation
t-bast
changed the title
BlockHeight wherever it makes senseBlockHeight type wherever it makes sense
t-bast
force-pushed
the
block-height-everywhere
branch
2 times, most recently
from
74c0c99 to
27ec8e0
Compare
t-bast
force-pushed
the
block-height-everywhere
branch
2 times, most recently
from
2d48a54 to
f282335
Compare
We now have this better type to remove ambiguity. We should use it wherever it makes sense. There shouldn't be any business logic change in this commit.
t-bast
force-pushed
the
block-height-everywhere
branch
from
f282335 to
eda3ee1
Compare
pm47
approved these changes
Jan 19, 2022
| } | ||
|
|
||
| object BlockHeight { | ||
| def apply(underlying: Int): BlockHeight = BlockHeight(underlying.toLong) |
Member
There was a problem hiding this comment.
Ha, should probably have done that for TimestampSecond and TimestampMilli.
Member
There was a problem hiding this comment.
Sure but then need to go over all tests to remove the L suffix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up after #2113