More aggressive confirmation target when low on utxos#2141
Merged
Conversation
An optimistic schedule for confirmation during force-close scenarios could in theory help malicious peers starve us of our utxos, making it hard to fee-bump HTLC transactions in high-fee environments. If we detect that our safe utxos count is low, we try to get force-close transactions confirmed as quickly as possible, which will yield a new utxo that can be used to fund other transactions.
Codecov Report
@@ Coverage Diff @@
## master #2141 +/- ##
==========================================
- Coverage 87.47% 87.43% -0.05%
==========================================
Files 170 170
Lines 13200 13216 +16
Branches 546 579 +33
==========================================
+ Hits 11547 11555 +8
- Misses 1653 1661 +8
|
pm47
previously approved these changes
Jan 24, 2022
| feeEstimator.getFeeratePerKw(blockTarget) | ||
| } else { | ||
| // We don't have many safe utxos so we want the transaction to confirm quickly. | ||
| feeEstimator.getFeeratePerKw(1) |
Member
There was a problem hiding this comment.
I know it makes sense to target one block here, but I'm afraid we overpay. How about two blocks?
eclair-core/src/main/scala/fr/acinq/eclair/channel/publish/ReplaceableTxPublisher.scala
Show resolved
Hide resolved
pm47
approved these changes
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #2113 is out of the way, we can start tweaking and making small improvements to the fee-bumping mechanism.
An optimistic schedule for confirmation during force-close scenarios could in theory help malicious peers starve us of our utxos, making it hard to fee-bump HTLC transactions in high-fee environments.
If we detect that our safe utxos count is low, we try to get force-close transactions confirmed as quickly as possible, which will yield a new utxo that can be used to fund other transactions.
This PR is a deterministic alternative to #2137