Skip to content

Add txId in logback.xml#2183

Merged
t-bast merged 1 commit intomasterfrom
tx-publish-logback
Feb 17, 2022
Merged

Add txId in logback.xml#2183
t-bast merged 1 commit intomasterfrom
tx-publish-logback

Conversation

@t-bast
Copy link
Member

@t-bast t-bast commented Feb 16, 2022

We changed the logging MDC key for tx-publishing in #2131, but forgot to add a formatting rule in logback.xml for that new field, so it wasn't written to logs.

We changed the logging MDC key for tx-publishing in #2131, but forgot to
add a formatting rule in logback.xml for that new field, so it wasn't
written to logs.
@t-bast t-bast requested a review from sstone February 16, 2022 16:03
@sstone
Copy link
Member

sstone commented Feb 16, 2022

LGTM but I find the PR description (and the choice of tag t: in logback.xml) a bit surprising as we're not using a bitcoin transaction id but rather a "publishing attempt id" which is a random id that is specific to eclair ?

@t-bast
Copy link
Member Author

t-bast commented Feb 16, 2022

What other letter would you use that would make more sense?
i (which could have been id) and p (which could have been publish) are already used...
We can change from t to something else, but I couldn't find a letter that made more sense (and we don't care that much to be honest, we're more interested in the value it carries).

@sstone
Copy link
Member

sstone commented Feb 16, 2022

Fair enough.

@t-bast t-bast merged commit 99aabda into master Feb 17, 2022
@t-bast t-bast deleted the tx-publish-logback branch February 17, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants