Skip to content

Refactor channel transitions#2228

Merged
t-bast merged 6 commits into
masterfrom
rename-has-commitments
Apr 7, 2022
Merged

Refactor channel transitions#2228
t-bast merged 6 commits into
masterfrom
rename-has-commitments

Conversation

@t-bast
Copy link
Copy Markdown
Member

@t-bast t-bast commented Apr 7, 2022

This PR contains changes from #2225 without the channel data type hierarchy changes.
It doesn't introduce a lot of functional changes, but they are quite sensitive: reviewers beware!
This is better reviewed commit-by-commit.

t-bast added 5 commits April 7, 2022 13:45
* Also introduce a TransientChannelData trait, which lets us have complete
  pattern matching in a few places.
* Remove channel data from the ChannelErrorOccured event.
* Rename channel data codec.
@t-bast t-bast requested a review from pm47 April 7, 2022 12:45
Comment thread eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala Outdated
Comment thread eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala Outdated
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2228 (eaa488b) into master (36ed788) will increase coverage by 0.02%.
The diff coverage is 80.64%.

@@            Coverage Diff             @@
##           master    #2228      +/-   ##
==========================================
+ Coverage   83.86%   83.88%   +0.02%     
==========================================
  Files         190      190              
  Lines       13967    13964       -3     
  Branches      585      578       -7     
==========================================
+ Hits        11713    11714       +1     
+ Misses       2254     2250       -4     
Impacted Files Coverage Δ
...n/scala/fr/acinq/eclair/balance/BalanceActor.scala 10.16% <ø> (ø)
...ala/fr/acinq/eclair/balance/ChannelsListener.scala 93.10% <ø> (ø)
...n/scala/fr/acinq/eclair/balance/CheckBalance.scala 66.30% <ø> (ø)
...c/main/scala/fr/acinq/eclair/channel/Helpers.scala 94.97% <ø> (ø)
...q/eclair/channel/fsm/ChannelOpenSingleFunder.scala 90.74% <ø> (ø)
...a/fr/acinq/eclair/channel/fsm/CommonHandlers.scala 90.00% <ø> (ø)
.../acinq/eclair/db/migration/CompareChannelsDb.scala 0.00% <0.00%> (ø)
.../acinq/eclair/db/migration/MigrateChannelsDb.scala 0.00% <0.00%> (ø)
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 90.41% <ø> (ø)
...rc/main/scala/fr/acinq/eclair/io/Switchboard.scala 85.41% <ø> (ø)
... and 17 more

@t-bast t-bast merged commit 446a780 into master Apr 7, 2022
@t-bast t-bast deleted the rename-has-commitments branch April 7, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants