Add anchor outputs zero fee spec test vector#2400
Merged
Merged
Conversation
As specified in lightning/bolts#1018
pm47
approved these changes
Sep 6, 2022
Member
pm47
left a comment
pm47
left a comment
There was a problem hiding this comment.
It doesn't look that hacky to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As specified in lightning/bolts#1018
Our test suite for those test vectors isn't very flexible as it depends on the test name and expects all commitment formats to have exactly the same set of tests, which isn't true for zero fee htlc txs where the feerate doesn't impact which htlcs materialize in the commit tx (only the dust limit impacts that).
It's a bit hacky, but I chose to make minimal modifications to the test file to fit the new tests in, it can be a bit confusing but I don't think it's worth refactoring as we shouldn't change this often.