Skip to content

Fix static default from and to pagination#2484

Merged
t-bast merged 3 commits into
masterfrom
fix-from-to-api
Nov 14, 2022
Merged

Fix static default from and to pagination#2484
t-bast merged 3 commits into
masterfrom
fix-from-to-api

Conversation

@t-bast
Copy link
Copy Markdown
Member

@t-bast t-bast commented Nov 14, 2022

The default values for the from and to parameters of some API requests were generated once when the eclair node starts instead of being recomputed for every request.

We also add count and skip argument to listPendingInvoices since it was added to listInvoices.

Fixes #2475

@t-bast
Fix static default from and to pagination
8763395 
The default values were generated once when the eclair node starts instead
of being recomputed for every request.

Fixes #2475
@t-bast
Add pagination to listPendingInvoice
e9ca2f0 
This is a follow-up for #2474: listing pending invoices should also benefit
from `skip` and `count` pagination.
@t-bast t-bast requested a review from pm47 November 14, 2022 10:24
@t-bast t-bast mentioned this pull request Nov 14, 2022
Merged
pm47
pm47 reviewed Nov 14, 2022
View reviewed changes
Comment thread eclair-node/src/main/scala/fr/acinq/eclair/api/directives/ExtraDirectives.scala Outdated
@t-bast
Simplify from and to
7e46cbf 
Just convert val to def instead of an explicit function.
pm47
pm47 approved these changes Nov 14, 2022
View reviewed changes
Comment thread eclair-node/src/main/scala/fr/acinq/eclair/api/directives/ExtraDirectives.scala
@t-bast t-bast merged commit 6eba3e7 into master Nov 14, 2022
@t-bast t-bast deleted the fix-from-to-api branch November 14, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pm47 pm47 pm47 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

listinvoices returns an incomplete list

2 participants

@t-bast @pm47