fixup! Fix flaky GossipIntegrationSpec test (#3039)#3061
Merged
remyers merged 1 commit intoACINQ:masterfrom Apr 14, 2025
Merged
fixup! Fix flaky GossipIntegrationSpec test (#3039)#3061remyers merged 1 commit intoACINQ:masterfrom
remyers merged 1 commit intoACINQ:masterfrom
Conversation
Apply same fix to Bob and Carol used for Alice. Race can result in `ExternalChannelSpent` being received by nodes after validating the channel update for a splice received from their peer. This will not happen in the wild. I checked that both paths are exercised for all three nodes.
remyers
force-pushed
the
flaky-gossip-fixup
branch
from
a82582b to
312e862
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3061 +/- ##
==========================================
+ Coverage 85.77% 85.82% +0.05%
==========================================
Files 235 235
Lines 21266 21279 +13
Branches 850 920 +70
==========================================
+ Hits 18240 18262 +22
+ Misses 3026 3017 -9 🚀 New features to boost your workflow:
|
t-bast
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply same fix to Bob and Carol used for Alice in PR #3039 .
A race can result in
ExternalChannelSpentbeing received by nodes after they validate the channel update for a splice received from their peer. This will not happen in the wild.I manually checked that both paths are exercised for all three nodes.