Conversation
t-bast
force-pushed
the
refactor-add-sigs
branch
from
05ebfb5 to
5c7be5d
Compare
Instead of having multiple overloads for `addSigs`, we move each one of them inside the corresponding `TransactionWithInputInfo`. This is part of an effort to group the logic belonging to each type of transaction in the same place to make it easier to review and use. This is a purely mechanical refactoring, where code has simply been cut and pasted. The only functional change is for `HtlcPenaltyTx`, where we incorrectly used the witness for a `MainPenaltyTx`, which was actually smaller. We were thus under-estimating the fees we had to pay to reach the desired feerate, which isn't much of an issue, but it's better to use the correct witness for consistency.
This field was unused, and quite confusing. We should remove it.
t-bast
force-pushed
the
refactor-add-sigs
branch
from
5c7be5d to
d0e20b8
Compare
sstone
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having multiple overloads for
addSigs, we move each one of them inside the correspondingTransactionWithInputInfo. This is part of an effort to group the logic belonging to each type of transaction in the same place to make it easier to review and use.This is a purely mechanical refactoring, where code has simply been cut and pasted. The only functional change is for
HtlcPenaltyTx, where we incorrectly used the witness for aMainPenaltyTx, which was actually smaller. We were thus under-estimating the fees we had to pay to reach the desired feerate, which isn't much of an issue, but it's better to use the correct witness for consistency.In the second commit, we remove the unused
minRelayFeefield.