Closed
Conversation
We update CommitmentOutput to include the actual output that it represents in the commit tx, and the redeem script to spend it. We also include 2nd level HTLC transactions when they are not trimmed. We remove CommitmentOutputLink which is now useless, and simplify how we create commitment and HTLC transactions.
sstone
force-pushed
the
refactor-commitment-outputs
branch
from
59cb049 to
c84d716
Compare
Member
|
Let's see if this works with the complete refactoring of transaction signing before merging this. If the approach I'm following that completely removes the redeem information works, we may not need this at all! And if it doesn't work, then it will confirm that we should merge this PR and build on top of it. |
Member
|
This change was included as part of #3074 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We update CommitmentOutput to include the actual output that it represents in the commit tx, and the redeem script to spend it. We also include 2nd level HTLC transactions when they are not trimmed. We remove CommitmentOutputLink which is now useless, and simplify how we create commitment and HTLC transactions.