Add more splice channel_reestablish tests#3094
Merged
remyers merged 6 commits intoACINQ:masterfrom Jun 4, 2025
Merged
Conversation
During splice interop testing I added new channel_reestablish tests to splice_tests.md of the splice spec. Some tests correspond to tests in splice_tests.md. I added the corresponding test name from splice_tests.md and test flow diagram to the matching spec tests.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3094 +/- ##
==========================================
+ Coverage 85.80% 85.96% +0.16%
==========================================
Files 236 237 +1
Lines 21299 21514 +215
Branches 859 868 +9
==========================================
+ Hits 18275 18494 +219
+ Misses 3024 3020 -4 🚀 New features to boost your workflow:
|
t-bast
reviewed
Jun 2, 2025
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala
Outdated
Show resolved
Hide resolved
Should reference 'Disconnection with both sides sending tx_signatures' test, not `one side sending` version.
t-bast
reviewed
Jun 4, 2025
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala
Outdated
Show resolved
Hide resolved
t-bast
approved these changes
Jun 4, 2025
Contributor
Author
|
Thanks for the close reading @t-bast! Should be good now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During splice interop testing I added new channel_reestablish tests to splice_tests.md of the splice spec.
Some tests correspond to tests in splice_tests.md. I added the corresponding test name from splice_tests.md and test flow diagram to the matching spec tests.