Merged
Conversation
t-bast
force-pushed
the
remove-legacy-commitment-format
branch
2 times, most recently
from
6dbd473 to
9e66e9f
Compare
t-bast
force-pushed
the
remove-legacy-commitment-format
branch
from
9e66e9f to
9399ce2
Compare
t-bast
force-pushed
the
remove-legacy-commitment-format
branch
2 times, most recently
from
58816b3 to
93fa59d
Compare
sstone
reviewed
Oct 15, 2025
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalStateSpec.scala
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/OfflineStateSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/f/ShutdownStateSpec.scala
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/h/ClosingStateSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/h/ClosingStateSpec.scala
Show resolved
Hide resolved
t-bast
force-pushed
the
remove-legacy-commitment-format
branch
from
93fa59d to
3693e12
Compare
Member
Author
|
I had to rebase because of conflicts, but most of the files should be unchanged since the last review. |
sstone
reviewed
Oct 16, 2025
eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
Outdated
Show resolved
Hide resolved
Member
Author
|
Note that I have added further clean-up in fa5e80c, as my work on v3 transactions showed that this field won't be necessary and can thus be removed right now (which simplifies the code even more). |
sstone
reviewed
Oct 16, 2025
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version5/ChannelCodecs5.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version5/ChannelCodecs5.scala
Outdated
Show resolved
Hide resolved
sstone
previously approved these changes
Oct 17, 2025
t-bast
force-pushed
the
remove-legacy-commitment-format
branch
from
4168507 to
a62fd6e
Compare
Member
Author
|
Rebased (without conflicts) and squashed to a single commit. |
t-bast
commented
Oct 24, 2025
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version5/ChannelCodecs5.scala
Outdated
Show resolved
Hide resolved
t-bast
force-pushed
the
remove-legacy-commitment-format
branch
4 times, most recently
from
231d665 to
f230129
Compare
We remove support for `static_remotekey` channels and `default` channels, as advertised in the v0.13 release. This lets us remove some code related to feerate management and simplifies the test matrix. Node operators that still have such channels must not run this version of `eclair`, which will otherwise fail to start. Note that for now, we keep sending `update_fee` whenever necessary. We could remove that now that package relay allows 1p1c packages to propagate even when the parent is below the mempool minimum feerate, but we defer that to a later PR for simplicity.
t-bast
force-pushed
the
remove-legacy-commitment-format
branch
from
f230129 to
27e3e62
Compare
pm47
approved these changes
Oct 27, 2025
sstone
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We remove support for
static_remotekeychannels anddefaultchannels, as advertised in the v0.13 release. This lets us remove some code related to feerate management and simplifies the test matrix.Node operators that still have such channels must not run this version of
eclair, which will otherwise fail to start.Note that for now, we keep sending
update_feewhenever necessary. We could remove that now that package relay allows 1p1c packages to propagate even when the parent is below the mempool minimum feerate, but we defer that to a later PR for simplicity.