Fix missing anchor amount included in fees#3194
Closed
t-bast wants to merge 2 commits intobitcoind-use-bech32mfrom
Closed
Fix missing anchor amount included in fees#3194t-bast wants to merge 2 commits intobitcoind-use-bech32mfrom
t-bast wants to merge 2 commits intobitcoind-use-bech32mfrom
Conversation
When addres type or change type is not specified, bitcoind will now start with addresstype=bech32m and changetype=bech32m. We take this opportunity to fix feerate tests that failed because of the following reasons: - first of all, we had a bug where we didn't take into account the anchor amount in our fee calculation, so we ended up always adding `330 sats` to the on-chain fees we paid, which was hidden by our tolerance interval, but started appearing with smaller p2tr inputs - then we fix the remaining tests that need manual tweaking of the utxos available in the test wallet, because they end up creating transactions where we don't have a change output (and overpay fees slightly, but not enough to make it worth adding a change output), these tests simply needed to be tweaked to accomodate p2tr weights Co-authored by @sstone
t-bast
force-pushed
the
bitcoind-use-bech32m-bast
branch
from
4b9cc9d to
be8162b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fix feerate tests that failed because of the following reasons:
330 satsto the on-chain fees we paid, which was hidden by our tolerance interval, but started appearing with smaller p2tr inputsNote that this PR targets #3191