Support option_simplified_commitment#887
Closed
araspitzu wants to merge 75 commits into
Closed
Conversation
…point in channel_reestablish
We don't use `signrawtransaction` anymore, which was deprecated in Bitcoin Core 0.17 and will be removed in 0.18. This means that we don't support 0.16.3 and older.
…implified_commitment
…lified_commitment
Check that we handle errors properly when signrawtransactionwithwallet returns multiple errors.
# Conflicts: # eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala # eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelExceptions.scala # eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelTypes.scala # eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala # eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala # eclair-core/src/main/scala/fr/acinq/eclair/crypto/KeyManager.scala # eclair-core/src/main/scala/fr/acinq/eclair/crypto/LocalKeyManager.scala # eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala # eclair-core/src/main/scala/fr/acinq/eclair/transactions/Scripts.scala # eclair-core/src/main/scala/fr/acinq/eclair/transactions/Transactions.scala # eclair-core/src/main/scala/fr/acinq/eclair/wire/ChannelCodecs.scala # eclair-core/src/test/scala/fr/acinq/eclair/channel/states/b/WaitForFundingCreatedStateSpec.scala # eclair-core/src/test/scala/fr/acinq/eclair/channel/states/b/WaitForFundingSignedStateSpec.scala # eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalStateSpec.scala # eclair-core/src/test/scala/fr/acinq/eclair/channel/states/g/NegotiatingStateSpec.scala # eclair-core/src/test/scala/fr/acinq/eclair/channel/states/h/ClosingStateSpec.scala # eclair-core/src/test/scala/fr/acinq/eclair/db/ChannelStateSpec.scala # eclair-core/src/test/scala/fr/acinq/eclair/db/SqliteAuditDbSpec.scala # eclair-core/src/test/scala/fr/acinq/eclair/transactions/TestVectorsSpec.scala # eclair-core/src/test/scala/fr/acinq/eclair/transactions/TransactionsSpec.scala
To reconstruct the tx commit number we need to take the lower 24 bits of the locktime field.
…ied_commitmeint_more_simplified # Conflicts: # eclair-core/src/test/scala/fr/acinq/eclair/transactions/TransactionsSpec.scala
araspitzu
changed the title
Contributor
Author
|
Closing because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the new commitment type with option_simplified_commitment. This PR proposes a non-typed design built on top of the existing Commitments class, there is now a version field that is used to identify the type of commitment being used; when we serialize the STATE_DATA the version is translated into a byte and prepended to the serialized state. Summary of the changes:
At the time of this writing there are still some open questions on the BOLTs themselves regarding option_simplified_commitment.