Only attempt to decrement orders after delete#30
Merged
ADmad merged 5 commits intoADmad:masterfrom Jul 9, 2019
Merged
Conversation
Owner
|
Tests failing. Simply changing the callback method won't cut it. All fields required to calculate the new orders might not be available in provided entity in which case the So the Also please add a test case using table with unique index for the sequence field 🙂. |
Contributor
Author
|
👍 |
Contributor
Author
|
@ADmad Should be all good now! |
ADmad
reviewed
Jul 8, 2019
| * records that were after it in the set. | ||
| * | ||
| * @param \Cake\Event\Event $event The beforeDelete event that was fired. | ||
| * @param \Cake\Event\Event $event The afterDelete event that was fired. |
| * records that were after it in the set. | ||
| * | ||
| * @param \Cake\Event\Event $event The afterDelete event that was fired. | ||
| * @param \Cake\ORM\Entity $entity The entity that is going to be saved. |
Contributor
Author
|
@ADmad Fixed. Can't believe I missed that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing this in the beforeDelete breaks in cases where the sequencing is a unique index.