Load .jpk-qi-data metadata using jpk-reader-rs package#45
Open
bicarlsen wants to merge 2 commits intoAFM-analysis:masterfrom
Open
Load .jpk-qi-data metadata using jpk-reader-rs package#45bicarlsen wants to merge 2 commits intoAFM-analysis:masterfrom
.jpk-qi-data metadata using jpk-reader-rs package#45bicarlsen wants to merge 2 commits intoAFM-analysis:masterfrom
Conversation
Contributor
Author
|
This also incorporates #44. |
remove backslash from hour and minute while parsing time. refactor optimize get_metadata
Contributor
Author
|
This new version optimizes Once this is more thouroughly tested, it should be good to go. There may also be some optimizations that can be applied elsewhere:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speeds up loading
.jpk-qi-datafiles by using thejpk-reader-rspackage to load metadata.Addresses #41, reducing load times of standard files by ~10x. For the test file it reduced the load time from more than 120 minutes to about 15.
I kept as much of the original
JPKReaderas possible for this first pass. There is still quite some performance to be gained though, as the same test file loads in 20 seconds from the Rust crate.While probably not yet ready to be merged, I'm hoping can use it so we can address any issues that arise and continue to imporve upon performance.