update test_eos to use composition runtime parameters

Docs/source/comprehensive_tests.rst

@@ -74,9 +74,6 @@ exercise all modes of calling the EOS, in order:
 
   We store the relative error in :math:`\rho` in the output file.
 
-This unit test is marked up with OpenMP directives and therefore also
-tests whether the EOS is threadsafe.
-
 To compile for a specific EOS, e.g., helmholtz, do::
 
     make EOS_DIR=helmholtz -j 4
@@ -99,13 +96,9 @@ each zone.
 The state in each zone of our data cube is determined by the runtime
 parameters ``dens_min``, ``dens_max``, ``temp_min``, and ``temp_max``
 for :math:`(\rho, T)`. Because each network carries different
-compositions, we specify the composition through runtime parameters in
-the ``&extern`` namelist: ``primary_species_1``,
-``primary_species_2``, ``primary_species_3``. These primary species
-will vary from X = 0.2 to X = 0.7 to 0.9 (depending on the number).
-Only one primary species varies at a time. The non-primary species
-will be set equally to share whatever fraction of 1 is not accounted
-for by the primary species mass fractions.
+compositions, we specify the composition through runtime parameters
+described in :ref:`sec:defining_unit_test_composition` for comprehensive
+tests.
 
 This test calls the network on each zone, running for a time
 ``tmax``. The full state, including new mass fractions and energy

Docs/source/unit_test_runtime_parameters.rst

@@ -46,12 +46,20 @@ initial mass-fractions, $X_k$).  There are a few ways this can be done
     ``unit_test.uniform_xn``.  If this is set to ``1``, then each mass fraction
     is initialized to ``1 / NumSpec``.
 
-* Comprehensive tests (see :ref:`sec:comprehensive_tests`) need many different compositions, since they are creating a cube
-
-  of varying thermodynamic properties, and thus require a prescription
-  to create the composition.  This is done by setting ``unit_test.primary_species_1``,
-  ``unit_test.primary_species_2``, and ``unit_test.primary_species_3`` to one of the
-  *names* of the species in the network.
+* Comprehensive tests (see :ref:`sec:comprehensive_tests`) need many
+  different compositions, since they are creating a cube of varying
+  thermodynamic properties, and thus require a prescription to create
+  the composition.  This is done by setting:
+
+  * ``unit_test.primary_species_1``
+  * ``unit_test.primary_species_2``
+  * ``unit_test.primary_species_3``
+
+  to one of the *names* of the species in the network.  These primary
+  species will vary from X = 0.2 to X = 0.7 to 0.9 (depending on the
+  number).  Only one primary species varies at a time. The non-primary
+  species will be set equally to share whatever fraction of 1 is not
+  accounted for by the primary species mass fractions.
 
   The function ``setup_composition()`` is then used to set limits on
   the species abundances (it takes a parameter which is the index into

unit_test/react_util.H

@@ -1,6 +1,7 @@
 #ifndef REACT_UTIL_H
 #define REACT_UTIL_H
 
+#include <network.H>
 #include <extern_parameters.H>
 
 using namespace amrex::literals;

unit_test/test_eos/_parameters

@@ -4,5 +4,3 @@ dens_min      real       1.e6
 dens_max      real       1.e9
 temp_min      real       1.e6
 temp_max      real       1.e12
-
-metalicity_max  real     0.1e0