Use autodiff in sneut5 #1799
Merged
Use autodiff in sneut5 #1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When these are passed as normal variables, the universal reference arguments seem to confuse nvcc, which produces errors like `identifier "nu_constants::oneth" is undefined in device code`. Explicitly casting to a prvalue first avoids this.
zingale
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intentionally changes as little as possible in terms of numeric operations, so the test results are consistent. We can probably clean up a lot of this later -- there are lots more temporary variables than needed, and
sneutf_tstores a bunch of powers ofxlmostly used for polynomials, which can use Horner's method instead.