-
Notifications
You must be signed in to change notification settings - Fork 40
update constant module to use scipy value and remove using legacy constants #1802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…alue. Also remove using legacy constant
|
I think that if we update G here, then the initial models that do self-gravity would need to be regenerated, since Castro would pick up this G. This is fine, but we should coordinate this carefully. |
Right, the old G is not updated. Only the new G is updated, and that's in comment. So its not being used actually |
|
I also updated the |
…nto update_constants
|
I think we will still need to update any Castro initial models that use gamma_law, since the constants are changing. |
|
from https://github.com/AMReX-Astro/initial_models, the only one i see is |
|
oh indeed. I thought it would be more. I'll review this today. |
|
can you add a page to the docs (perhaps just in the "Microphysics overview" section, that discusses the constants and the script used to generate the header? |
This reverts commit 1f4f4f0.
added a script to auto generate scipy constant value. Address issue #1655.