Skip to content

Conversation

@zhichen3
Copy link
Collaborator

@zhichen3 zhichen3 commented Jun 6, 2025

added a script to auto generate scipy constant value. Address issue #1655.

@zingale
Copy link
Member

zingale commented Jun 6, 2025

I think that if we update G here, then the initial models that do self-gravity would need to be regenerated, since Castro would pick up this G. This is fine, but we should coordinate this carefully.

@zhichen3
Copy link
Collaborator Author

zhichen3 commented Jun 6, 2025

I think that if we update G here, then the initial models that do self-gravity would need to be regenerated, since Castro would pick up this G. This is fine, but we should coordinate this carefully.

Right, the old G is not updated. Only the new G is updated, and that's in comment. So its not being used actually

@zhichen3
Copy link
Collaborator Author

zhichen3 commented Jun 7, 2025

I also updated the burn_cell_metal_chem unit test script to get the "correct" line number. Previously the test actually results in some integration failure, to see that grep for fail in test_*.out. With this pr, we no longer see those failure. So the reference line number changed, resulting in comparison between different quantities. Here I updated it and the test passes.

@zingale
Copy link
Member

zingale commented Jun 7, 2025

@zingale
Copy link
Member

zingale commented Jun 7, 2025

I think we will still need to update any Castro initial models that use gamma_law, since the constants are changing.

@zhichen3
Copy link
Collaborator Author

zhichen3 commented Jun 7, 2025

from https://github.com/AMReX-Astro/initial_models, the only one i see is low_mass_convective_star?

@zingale
Copy link
Member

zingale commented Jun 7, 2025

oh indeed. I thought it would be more. I'll review this today.

@zingale
Copy link
Member

zingale commented Jun 7, 2025

@zingale
Copy link
Member

zingale commented Jun 7, 2025

can you add a page to the docs (perhaps just in the "Microphysics overview" section, that discusses the constants and the script used to generate the header?

@zingale zingale merged commit 4e96587 into AMReX-Astro:development Jun 7, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants