Update sneut5 to use partial arrays #1808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decreases the runtime on CPU from 1.81s to 1.45s (-20%), compared to PR AMReX-Astro#1803. It's still 25% slower than the original hand-written derivatives, which I believe is mostly due to the creation of extra temporary GradArrays in the autodiff code.
yut23
force-pushed
the
sneut5-partial-arrays
branch
from
5ebf787 to
0fa11b4
Compare
zingale
reviewed
Jun 23, 2025
zingale
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decreases the runtime on CPU from 1.81s to 1.45s (-20%), compared to current development (f3ca377). It's still 25% slower than the original hand-written derivatives, which I believe is mostly due to the creation of extra temporary GradArrays in the autodiff code.