-
Notifications
You must be signed in to change notification settings - Fork 40
update nse_sdc_burn for NSE_NET #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
After fixing the abar calculation, CI test shows that we fully recover the internal energy. |
|
this is really cool. Do you understand why we don';t need to do the same finite-difference estimate of the update as we do with the tabular NSE here? |
|
I'm not sure. One thing that's not being tested here is I don't have any weak rates in the network, so the energy generation from reaction is exactly zero. I should probably make a network and test that. |
|
updated the docs |





Addresses the following: